Rename Client to X11Client
ffcbe24e2bf9
Actions

Authored by zzag on Sep 24 2019, 8:48 AM.

Description

Rename Client to X11Client

Summary:
Currently each managed X11 client is represented with an instance of
Client class, however the name of that class is very generic and the
only reason why it's called that way is because historically kwin
was created as an x11 window manager, so "Client" was a sensible choice.

With introduction of wayland support, things had changed and therefore
Client needs to be renamed to X11Client in order to better reflect what
that class stands for.

Renaming of Client to X11Client was agreed upon during the last KWin
sprint.

Test Plan: Compiles, the test suite is still green.

Reviewers: KWin, romangg

Reviewed By: KWin, romangg

Subscribers: romangg, davidedmundson, kwin

Tags: KWin

Differential Revision: https://phabricator.kde.org/D24184

Details

Committed

zzag	Sep 25 2019, 6:11 PM

Reviewer

KWin

Differential Revision

D24184: Rename Client to X11Client

Parents

R108:a486b471e1a4: [kcmkwin/compositing] Hide animation speed slider on Plasma

Branches

Unknown

Tags

Unknown

zzag committed R108:ffcbe24e2bf9: Rename Client to X11Client (authored by zzag).Sep 25 2019, 6:11 PM

Changes (100)

				Path	Packages
	M			CMakeLists.txt
	M			abstract_client.cpp
	M			activation.cpp
	M			activities.cpp
	M			activities.h
	M			appmenu.cpp
	M			autotests/CMakeLists.txt
	D			autotests/client.h
	M			autotests/integration/activities_test.cpp
	M			autotests/integration/dbus_interface_test.cpp
	M			autotests/integration/desktop_window_x11_test.cpp
	M			autotests/integration/dont_crash_aurorae_destroy_deco.cpp
	M			autotests/integration/dont_crash_cancel_animation.cpp
	M			autotests/integration/dont_crash_cursor_physical_size_empty.cpp
	M			autotests/integration/dont_crash_empty_deco.cpp
	M			autotests/integration/dont_crash_glxgears.cpp
	M			autotests/integration/dont_crash_no_border.cpp
	M			autotests/integration/effects/slidingpopups_test.cpp
	M			autotests/integration/effects/translucency_test.cpp
	M			autotests/integration/effects/wobbly_shade_test.cpp
	M			autotests/integration/globalshortcuts_test.cpp
	M			autotests/integration/move_resize_window_test.cpp
	M			autotests/integration/plasmawindow_test.cpp
	M			autotests/integration/quick_tiling_test.cpp
	M			autotests/integration/scene_qpainter_test.cpp
	M			autotests/integration/screenedge_client_show_test.cpp
	M			autotests/integration/shade_test.cpp
	M			autotests/integration/stacking_order_test.cpp
	M			autotests/integration/struts_test.cpp
	M			autotests/integration/window_rules_test.cpp
	M			autotests/integration/x11_client_test.cpp
	M			autotests/integration/xwayland_input_test.cpp
	V			autotests/{mock_client.cpp → mock_x11client.cpp}
	V			autotests/{mock_client.h → mock_x11client.h}
	M			autotests/mock_workspace.h
	V			autotests/{mock_x11client.cpp ← mock_client.cpp}
	V			autotests/{mock_x11client.h ← mock_client.h}
	M			autotests/test_screen_edges.cpp
	M			autotests/test_screens.cpp
	A			autotests/x11client.h
	V			{client.cpp → x11client.cpp}
	V			{client.h → x11client.h}
	M			composite.cpp
	M			composite.h
	M			debug_console.cpp
	M			debug_console.h
	M			deleted.cpp
	M			effects.cpp
	M			effects.h
	M			events.cpp
	M			focuschain.h
	M			geometry.cpp
	M			group.cpp
	M			group.h
	M			input.cpp
	M			layers.cpp
	M			manage.cpp
	M			moving_client_x11_filter.cpp
	M			netinfo.cpp
	M			netinfo.h
	M			placement.cpp
	M			plugins/platforms/x11/standalone/sync_filter.cpp
	M			plugins/platforms/x11/standalone/windowselector.cpp
	M			plugins/platforms/x11/standalone/x11_decoration_renderer.cpp
	M			plugins/scenes/opengl/lanczosfilter.cpp
	M			plugins/scenes/opengl/scene_opengl.cpp
	M			plugins/scenes/qpainter/scene_qpainter.cpp
	M			plugins/scenes/xrender/scene_xrender.cpp
	M			pointer_input.cpp
	M			rules.cpp
	M			rules.h
	M			scene.cpp
	M			screenedge.cpp
	M			screens.cpp
	M			scripting/meta.cpp
	M			scripting/meta.h
	M			scripting/scripting.cpp
	M			scripting/scripting.h
	M			scripting/scripting_model.cpp
	M			scripting/workspace_wrapper.cpp
	M			scripting/workspace_wrapper.h
	M			sm.cpp
	M			sm.h
	M			tabbox/tabbox.cpp
	M			tabbox/tabbox.h
	M			thumbnailitem.cpp
	M			toplevel.cpp
	M			useractions.cpp
	M			useractions.h
	M			utils.h
	M			wayland_server.cpp
	M			window_property_notify_x11_filter.cpp
	M			workspace.cpp
	M			workspace.h
	V			{x11client.cpp ← client.cpp}
	V			{x11client.h ← client.h}
	M			xwl/clipboard.cpp
	M			xwl/dnd.cpp
	M			xwl/drag_wl.cpp
	M			xwl/selection.cpp

Rename Client to X11Clientffcbe24e2bf9Actions

Description

Details

Changes (100)

R108:ffcbe24e2bf9

CMakeLists.txt

abstract_client.cpp

activation.cpp

activities.cpp

activities.h

appmenu.cpp

autotests/CMakeLists.txt

autotests/client.h

autotests/integration/activities_test.cpp

autotests/integration/dbus_interface_test.cpp

autotests/integration/desktop_window_x11_test.cpp

autotests/integration/dont_crash_aurorae_destroy_deco.cpp

autotests/integration/dont_crash_cancel_animation.cpp

autotests/integration/dont_crash_cursor_physical_size_empty.cpp

autotests/integration/dont_crash_empty_deco.cpp

autotests/integration/dont_crash_glxgears.cpp

autotests/integration/dont_crash_no_border.cpp

autotests/integration/effects/slidingpopups_test.cpp

autotests/integration/effects/translucency_test.cpp

autotests/integration/effects/wobbly_shade_test.cpp

autotests/integration/globalshortcuts_test.cpp

autotests/integration/move_resize_window_test.cpp

autotests/integration/plasmawindow_test.cpp

autotests/integration/quick_tiling_test.cpp

autotests/integration/scene_qpainter_test.cpp

autotests/integration/screenedge_client_show_test.cpp

autotests/integration/shade_test.cpp

autotests/integration/stacking_order_test.cpp

autotests/integration/struts_test.cpp

autotests/integration/window_rules_test.cpp

autotests/integration/x11_client_test.cpp

autotests/integration/xwayland_input_test.cpp

autotests/mock_client.cpp

autotests/mock_client.h

autotests/mock_workspace.h

autotests/mock_x11client.cpp

autotests/mock_x11client.h

autotests/test_screen_edges.cpp

autotests/test_screens.cpp

autotests/x11client.h

client.cpp

client.h

composite.cpp

composite.h

debug_console.cpp

debug_console.h

deleted.cpp

effects.cpp

effects.h

events.cpp

focuschain.h

geometry.cpp

group.cpp

group.h

input.cpp

layers.cpp

manage.cpp

moving_client_x11_filter.cpp

netinfo.cpp

netinfo.h

placement.cpp

plugins/platforms/x11/standalone/sync_filter.cpp

plugins/platforms/x11/standalone/windowselector.cpp

plugins/platforms/x11/standalone/x11_decoration_renderer.cpp

plugins/scenes/opengl/lanczosfilter.cpp

plugins/scenes/opengl/scene_opengl.cpp

plugins/scenes/qpainter/scene_qpainter.cpp

plugins/scenes/xrender/scene_xrender.cpp

pointer_input.cpp

rules.cpp

rules.h

scene.cpp

screenedge.cpp

screens.cpp

scripting/meta.cpp

Rename Client to X11Client
ffcbe24e2bf9
Actions