Diffusion KWin e918cb5d2d3d

[effects/desktopgrid] Don't change activities

Authored by zzag on Jul 11 2018, 12:40 PM.

Description

[effects/desktopgrid] Don't change activities

Summary:
If the Desktop Grid effect doesn't use the Present Windows effect to
layout windows, windowAt helper can return a window that doesn't belong
to current activity because it doesn't check whether that window belongs
to current activity.

This change addresses that problem by adding corresponding check.

BUG: 301447
FIXED-IN: 5.13.4

Test Plan:
Unchecked "Use Present Windows effect to layout the windows".

  • Switched to activity #1
  • Switched to virtual desktop #1
  • Launched Konsole and maximized it(to increate hit area)
  • Switched to activity #2
  • Switched to virtual desktop #2
  • Launched Dolphin and maximized it
  • Activated the Desktop Grid effect, clicked on virtual desktop #1 (activity #2 is still active)
  • Switched to activity #1
  • Activated the Desktop Grid effect, clicked on virtual desktop #2 (activity #1 is still active)

Reviewers: KWin, davidedmundson

Reviewed By: KWin, davidedmundson

Subscribers: kwin

Tags: KWin

Differential Revision: https://phabricator.kde.org/D14046

Details

Committed
zzagAug 27 2019, 5:22 AM
Reviewer
KWin
Differential Revision
D14046: [effects/desktopgrid] Don't change activities
Parents
R108:bc3db8ba977c: SVN_SILENT made messages (.desktop file) - always resolve ours
Branches
Unknown
Tags
Unknown