Remove vsync detection and configurability
b3a19f9e5b77
Actions

Authored by romangg on Aug 27 2019, 8:23 PM.

Description

Remove vsync detection and configurability

Summary:
Selecting not to vsync does not make sense for an X11 compositor. In the end
we want clients to be able to present async if they want to but the compositor
is supposed to send swaps with vsync to the XServer in order to not generate
tearing artifacts.

There was also a detection logic which did some questionable things in case
vsync was not available. I don't think this is necessary at all since we can
just always run a timer to present with or without vsync.

Test Plan: kwin_x11 tested on i915.

Reviewers: KWin, zzag

Subscribers: zzag, kwin

Tags: KWin

Maniphest Tasks: T11071

Differential Revision: https://phabricator.kde.org/D23511

Details

Committed

romangg

Nov 14 2019, 7:55 AM

Differential Revision

D23511: Remove vsync detection and configurability

Parents

R108:285adc1950c9: [platforms/x11/standalone] Remove SGI swap control and video sync

Branches

Unknown

Tags

Unknown

Reverted By

R108:bcf64af49bd9: Revert "Remove vsync detection and configurability"

romangg committed R108:b3a19f9e5b77: Remove vsync detection and configurability (authored by romangg).Nov 14 2019, 7:55 AM

romangg added a reverting change: R108:bcf64af49bd9: Revert "Remove vsync detection and configurability".Jan 16 2020, 9:07 AM

Changes (17)

				Path	Packages
	M			composite.cpp
	M			kcmkwin/kwincompositing/compositing.cpp
	M			kcmkwin/kwincompositing/compositing.ui
	M			options.cpp
	M			options.h
	M			platformsupport/scenes/opengl/backend.cpp
	M			platformsupport/scenes/opengl/backend.h
	M			plugins/platforms/drm/egl_gbm_backend.cpp
	M			plugins/platforms/drm/egl_stream_backend.cpp
	M			plugins/platforms/hwcomposer/egl_hwcomposer_backend.cpp
	M			plugins/platforms/x11/common/eglonxbackend.cpp
	M			plugins/platforms/x11/standalone/glxbackend.cpp
	M			plugins/platforms/x11/standalone/glxbackend.h
	M			plugins/scenes/opengl/scene_opengl.cpp
	M			plugins/scenes/opengl/scene_opengl.h
	M			scene.cpp
	M			scene.h

Remove vsync detection and configurabilityb3a19f9e5b77Actions

Description

Details

Changes (17)

R108:b3a19f9e5b77

composite.cpp

kcmkwin/kwincompositing/compositing.cpp

kcmkwin/kwincompositing/compositing.ui

options.cpp

options.h

platformsupport/scenes/opengl/backend.cpp

platformsupport/scenes/opengl/backend.h

plugins/platforms/drm/egl_gbm_backend.cpp

plugins/platforms/drm/egl_stream_backend.cpp

plugins/platforms/hwcomposer/egl_hwcomposer_backend.cpp

plugins/platforms/x11/common/eglonxbackend.cpp

plugins/platforms/x11/standalone/glxbackend.cpp

plugins/platforms/x11/standalone/glxbackend.h

plugins/scenes/opengl/scene_opengl.cpp

plugins/scenes/opengl/scene_opengl.h

scene.cpp

scene.h

Remove vsync detection and configurability
b3a19f9e5b77
Actions