Diffusion KWin ad28da84e78c

[effects/slidingpopups] Don't crash when sliding virtual desktops

Authored by zzag on Nov 5 2018, 12:59 PM.

Description

[effects/slidingpopups] Don't crash when sliding virtual desktops

Summary:
If you switch virtual desktops while krunner is sliding in, then
depending on whether your distro strips assert statements away,
KWin can crash.

The reason why it crashes is the sliding popups effect tries to unref
deleted windows that it hasn't referenced before (if there is an active
full screen effect, then popups won't be slided out, which in its turn
means that we won't reference deleted windows). So, in the end, the
refcount of those windows can be -1. That triggers an assert statement
in the destructor of the Deleted class, which checks whether the
refcount is equal to 0.

Popups are not slided while there is an active full screen effect because
we don't know what the full screen effect does.

This patch adjusts the sliding popups effect so it stops all active
animations when user switches virtual desktops or when a full screen
effect kicks in. We need to do that so the effect won't try to
unreference windows in postPaintWindow.

Visually, it doesn't look quite nice, but for now that's good enough.
A proper fix would be more complex: we would need to make sure that
full screen effects ignore sliding popups (and also maybe docks) and
perform some input redirection.

BUG: 400170
FIXED-IN: 5.14.4

Test Plan: I'm not able anymore to reproduce bug 400170.

Reviewers: KWin, graesslin

Reviewed By: KWin, graesslin

Subscribers: davidedmundson, graesslin, kwin

Tags: KWin

Differential Revision: https://phabricator.kde.org/D16731

Details

Committed
zzagNov 7 2018, 5:22 PM
Reviewer
KWin
Differential Revision
D16731: [effects/slidingpopups] Don't crash when sliding virtual desktops
Parents
R108:18ff5969966a: Update version number for 5.14.3 GIT_SILENT
Branches
Unknown
Tags
Unknown