Diffusion KWin 80da18a143f1

[decorations] Emit DecorationSettings::fontChanged signal

Authored by zzag on Nov 15 2018, 5:40 PM.

Description

[decorations] Emit DecorationSettings::fontChanged signal

Summary:
No one emits DecorationSettings::fontChanged signal, so if you change
the window title font, then titlebars might look differently after reboot.

Currently, there are two places where we can emit that signal:

  • in KDecoration library itself;
  • and in KWin.

Because we would need to listen for a Plasma specific D-Bus signal, the
latter option is preferable.

Surprisingly, KWin's implementation of DecorationSettingsPrivate already
reacts to refreshFonts D-Bus signal (even though indirectly), so all
what we have to do is get the current window title font in
SettingsImpl::readSettings, and if it's different from the previous one,
emit DecorationSettings::fontChanged signal.

BUG: 400980
FIXED-IN: 5.15.0

Test Plan:

  • Increased the size of the window title font, titlebars got bigger;
  • Decreased the font size, titlebars got smaller.

Reviewers: KWin, davidedmundson

Reviewed By: KWin, davidedmundson

Subscribers: kwin

Tags: KWin

Differential Revision: https://phabricator.kde.org/D16908

Details

Committed
zzagNov 15 2018, 8:08 PM
Reviewer
KWin
Differential Revision
D16908: [decorations] Emit DecorationSettings::fontChanged signal
Parents
R108:841750438b45: Fix KeyboardLayoutTest::testNumLock
Branches
Unknown
Tags
Unknown