Diffusion KWin 70d2fb2378d6

Avoid a crash on Kwin decoration KCM teardown

Authored by davidedmundson on Feb 10 2017, 9:52 AM.

Description

Avoid a crash on Kwin decoration KCM teardown

Summary:
As described in https://bugreports.qt.io/browse/QTBUG-57714 exposing a
QWidget as a context item to QtQuick can crash. Especially as the
engine's context property gets deleted whilst deleting the parent item.

This patch reworks the code so that the models are exposed to QML
directly rather than going through a QWidget.

CCBUG: 373628

Test Plan:
Pressing back whilst in the decoration KCM used to crash every time, now it doesn't.
I still have the buttons.

Reviewers: Plasma, graesslin

Reviewed By: Plasma, graesslin

Subscribers: graesslin, cfeck, plasma-devel

Tags: Plasma

Differential Revision: https://phabricator.kde.org/D4533

Details

Committed
davidedmundsonFeb 10 2017, 1:01 PM
Reviewer
Plasma
Differential Revision
D4533: Avoid a crash on Kwin decoration KCM teardown
Parents
R108:5a87fa3f92cf: Support modifier-only-shortcuts when capslock is on
Branches
Unknown
Tags
Unknown