Diffusion KWin 67444e36592e

[effects/screenshot] Upload data to xpixmap in chunks

Authored by zzag on May 23 2019, 6:21 PM.

Description

[effects/screenshot] Upload data to xpixmap in chunks

Summary:
xcb_put_image doesn't handle big images well. Contrary to XPutImage, the
caller must manually split the data in such a way that each xcb_put_image
request doesn't exceed the maximum request length. Not doing so will result
in libxcb shutting down the connection.

CCBUG: 338489
CCBUG: 388182

Test Plan: Take a screenshot of an active fullscreen client on a 4K monitor.

Reviewers: KWin, davidedmundson

Reviewed By: KWin, davidedmundson

Subscribers: davidedmundson, kwin

Tags: KWin

Differential Revision: https://phabricator.kde.org/D21370

Details

Committed
zzagMay 27 2019, 2:30 PM
Reviewer
KWin
Differential Revision
D21370: [effects/screenshot] Upload data to xpixmap in chunks
Parents
R108:a9bfec5f16b4: SVN_SILENT made messages (.desktop file) - always resolve ours
Branches
Unknown
Tags
Unknown