Diffusion KWin 548978bfe1f7

[xwl] Drag and drop between Xwayland and Wayland native clients

Authored by romangg on Aug 22 2018, 12:56 PM.


[xwl] Drag and drop between Xwayland and Wayland native clients

Building upon the generic X Selection support this patch establishes another
selection class representing the XDND selection and provides interfaces
to communicate drags originating from Xwayland windows to the Wayland
server KWin and drags originating from Wayland native drags to Xwayland.

For Wayland native drags KWin will claim the XDND selection as owner and
will simply translate all relevant events to the XDND protocol and receive
alike messages by X clients.

When an X client claims the XDND selection KWin is notified via the X protocol
and it decides if it allows the X drag to transcend into the Wayland protocol.
If this is the case the mouse position is tracked and on entering a Wayland
native window a proxy X Window is mapped to the top of the window stack. This
proxy window acts as a drag destination for the drag origin window and again
X messages will be translated into respective Wayland protocol calls. If the
cursor leaves the Wayland window geometry before a drop is registered, the
proxy window is unmapped, what triggers a subsequent drag leave event.

In both directions the necessary core integration is minimal. There is a single
call to be done in the drag and drop event filter through the Xwayland
interface class.

From my tests this patch facilitates drags between any Qt/KDE apps. What needs
extra care are the browsers, which use target formats, that are not directly
compatible with the Wayland protocol's MIME representation. For Chromium an
additional integration step must be done in order to provide it with a net
window stack containing the proxy window.

Test Plan: Manually. Auto tests planned.

Reviewers: KWin

Subscribers: zzag, kwin, alexde

Tags: KWin

Maniphest Tasks: T4611

Differential Revision: https://phabricator.kde.org/D15627


romanggFeb 19 2019, 12:09 PM
Differential Revision
D15627: [xwl] Drag and drop between Xwayland and Wayland native clients
R108:ad1bcbecc789: [xwl] Add Xwayland interface class