Diffusion KWin 3f4995fb9b4f

Refactor the specification of OpenGL context attributes

Authored by graesslin on Jun 26 2017, 4:56 AM.


Refactor the specification of OpenGL context attributes

The current way to specify the OpenGL context attributes does no longer
scale as can be seen in D6344. There are too many different context
attribute sets and with every addition we grow lots of copied code. The
chances to introduce errors in that code which is difficult to debug are
very high. As can be seen in the glx backend which defines major 1,
minor 2, but it should be major 2, minor 1.

This change reworks this code by creating a builder class which contains
only an abstract definition of what needs to be in the attributes.
E.g. the version, whether it's robust and so on.

Now we can just have a list of possible attributes in a well described

auto builder;
builder.setVersion(3, 1);

All possible builders are added to a list and operated on in a for loop
which tries to creat a context. Once it succeeded it breaks the list.
In addition a debug statement is added which prints out the set of
options which went into the context.

So far this is only done for EGL, GLX can follow once D6344 is merged.

Test Plan: New unit test added, kwin_wayland OpenGL tests run and verified

Reviewers: KWin, Plasma

Subscribers: plasma-devel, kwin

Tags: KWin

Differential Revision: https://phabricator.kde.org/D6396


graesslinJun 26 2017, 8:13 PM
Differential Revision
D6396: Refactor the specification of OpenGL context attributes
R108:a6d0bc276d26: Merge branch 'Plasma/5.10'