Diffusion KWin 38e22ce6d18c

[platforms/x11] Properly unload effects on X11

Authored by zzag on Mar 11 2019, 7:23 AM.

Description

[platforms/x11] Properly unload effects on X11

Summary:
When Compositor finishes compositing, it destroys EffectsHandlerImpl,
which in its turn tries to unload all effects. But there is a problem...

EffectsHandlerImpl has platform-specific hooks to ungrab keyboard and
also stop mouse interception. Given that any call made to a virtual function
in the destructor of a base class(EffectsHandlerImpl) won't go to a derived
class(EffectsHandlerImplX11), keyboard won't be ungrabbed even if effect
that grabbed it is already gone.

BUG: 399572

Reviewers: KWin, davidedmundson

Reviewed By: KWin, davidedmundson

Subscribers: kwin

Tags: KWin

Differential Revision: https://phabricator.kde.org/D19178

Details

Committed
zzagMar 11 2019, 7:23 AM
Reviewer
KWin
Differential Revision
D19178: [platforms/x11] Properly unload effects on X11
Parents
R108:a9e469bf13f6: Properly restore current desktop from session
Branches
Unknown
Tags
Unknown