Diffusion KWin 10e99f64c1e1

[effects/sheet] Grab modal windows

Authored by zzag on Aug 2 2018, 1:44 PM.

Description

[effects/sheet] Grab modal windows

Summary:
If both the Glide effect and the Sheet effect are enabled,
they will conflict. Expected behavior would be:

  • the Sheet effect animates only modal windows;
  • the Glide effect animates the rest of normal windows.

In order to resolve the conflict, the Sheet effect has to grab
modal windows. Because it's quite specialized effect, we have
to ignore whether modal windows have been grabbed by the
Glide effect.

Test Plan:

  • Enabled both the Glide effect and the Sheet effect;
  • Opened Kate;
  • Opened "Open file" dialog;
  • Closed the dialog.

Reviewers: KWin, davidedmundson

Reviewed By: KWin, davidedmundson

Subscribers: abetts, davidedmundson, kwin

Tags: KWin

Differential Revision: https://phabricator.kde.org/D14560

Details

Committed
zzagAug 8 2018, 8:04 AM
Reviewer
KWin
Differential Revision
D14560: [effects/sheet] Grab modal windows
Parents
R108:3332b32101d7: [scripting] Fix effect.animate() curve argument being actually used
Branches
Unknown
Tags
Unknown