Avoid giving an stderr to kwallet

Authored by maximilianocuria on May 4 2018, 8:06 PM.

Description

Avoid giving an stderr to kwallet

Summary:
The fixes for CVE-2018-10380 introduced a regression for most users not
using kde, and some for kde sessions. In particular the reorder of the
close calls and creating a new socket caused that the socket is always
assigned the file descriptor 2, aka stderr.

BUG: 393856

Test Plan: It works

Reviewers: Plasma, aacid

Reviewed By: aacid

Subscribers: asturmlechner, rdieter, davidedmundson, plasma-devel

Tags: Plasma

Differential Revision: https://phabricator.kde.org/D12702

Details

Committed
maximilianocuriaMay 5 2018, 10:00 AM
Reviewer
aacid
Differential Revision
D12702: Avoid giving an stderr to kwallet
Parents
R107:01d4143fda5b: Move socket creation to unprivileged codepath
Branches
Unknown
Tags
Unknown