Paste P393

Masterwork From Distant Lands
ActivePublic
Actions

Authored by dkazakov on May 24 2019, 10:20 AM.
diff --git a/libs/pigment/compositeops/KoCompositeOps.h b/libs/pigment/compositeops/KoCompositeOps.h
index 33b8d2b..e11e909 100644
--- a/libs/pigment/compositeops/KoCompositeOps.h
+++ b/libs/pigment/compositeops/KoCompositeOps.h
@@ -94,9 +94,19 @@ template<>
struct OptimizedOpsSelector<KoRgbF32Traits>
{
static KoCompositeOp* createAlphaDarkenOp(const KoColorSpace *cs) {
- return useCreamyAlphaDarken() ?
- KoOptimizedCompositeOpFactory::createAlphaDarkenOpCreamy128(cs) :
- KoOptimizedCompositeOpFactory::createAlphaDarkenOpHard128(cs);
+
+ // TODO: optimized code is disabled for 4.2 release,
+ // becasue it causes bug https://bugs.kde.org/show_bug.cgi?id=404133
+ if (useCreamyAlphaDarken()) {
+ return new KoCompositeOpAlphaDarken<KoRgbF32Traits, KoAlphaDarkenParamsWrapperCreamy>(cs);
+ } else {
+ return new KoCompositeOpAlphaDarken<KoRgbF32Traits, KoAlphaDarkenParamsWrapperHard>(cs);
+ }
+
+ // TODO: please restore this optimized version when the bug is fixed
+// return useCreamyAlphaDarken() ?
+// KoOptimizedCompositeOpFactory::createAlphaDarkenOpCreamy128(cs) :
+// KoOptimizedCompositeOpFactory::createAlphaDarkenOpHard128(cs);
}
static KoCompositeOp* createOverOp(const KoColorSpace *cs) {
return KoOptimizedCompositeOpFactory::createOverOp128(cs);
dkazakov edited the content of this paste. (Show Details)May 24 2019, 10:20 AM
dkazakov changed the title of this paste from untitled to Masterwork From Distant Lands.