Allow longer app names in titlebar without eliding
ClosedPublic

Authored by ngraham on Jan 20 2018, 5:55 PM.

Details

Summary

Previously, long app names in the titlebar were elided based on an arbitrary criteria of being 1/2 the toolbar width. Now they are elided only when they no longer fit at all.

Test Plan

Tested in KDE Neon.

  • No visual change for most app names, which are short
  • Long app names are now only elided when they actually no longer fit in the space

Before:

After:

Diff Detail

Repository
R134 Discover Software Store
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ngraham created this revision.Jan 20 2018, 5:55 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 20 2018, 5:55 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
ngraham requested review of this revision.Jan 20 2018, 5:55 PM
ngraham edited the test plan for this revision. (Show Details)Jan 20 2018, 5:56 PM
ngraham edited the test plan for this revision. (Show Details)Jan 20 2018, 6:10 PM
apol accepted this revision.Jan 28 2018, 2:20 PM

Please test properly in all cases before pushing.

This revision is now accepted and ready to land.Jan 28 2018, 2:20 PM
This revision was automatically updated to reflect the committed changes.

Yup, I've been running with this for a week; no issues seen.