Differential D9979

[Notifications] Disable history check box when notifications are disabled
ClosedPublic
Actions

Authored by broulik on Jan 19 2018, 8:58 AM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
VDG
Commits
R120:c81a0151f50e: [Notifications] Disable history check box when notifications are disabled
R120:19882776a9f8: [Notifications] Disable history check box when notifications are disabled
Summary

You cannot have a history of notifications if you don't get any notifications in the first place.
Also move checkbox below notification history as it's semantically related.

Test Plan

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jan 19 2018, 8:58 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 19 2018, 8:58 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jan 19 2018, 8:58 AM
broulik retitled this revision from [Notifications] Disable history check box when history is disabled to [Notifications] Disable history check box when notifications are disabled.
broulik edited the summary of this revision. (Show Details)
davidedmundson accepted this revision.Jan 19 2018, 9:39 AM
This revision is now accepted and ready to land.Jan 19 2018, 9:39 AM
Closed by commit R120:c81a0151f50e: [Notifications] Disable history check box when notifications are disabled (authored by broulik). · Explain WhyJan 19 2018, 9:57 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 25628

View Options

applets/notifications/package/contents/ui/configNotifications.qml

Loading...