Differential D996

Use background priority for all clang parse threads.
ClosedPublic
Actions

Authored by mwolff on Feb 20 2016, 10:46 PM.

Tags

Subscribers

kfunk, kdevelop-devel

Details

Reviewers

Group Reviewers

Commits

R32:ec3bcd1d40a8: Use background priority for clang parse threads.

Summary

This sounds like a useful thing to do and should reduce potential
UI lockups when the parse threads are busy.

Test Plan

all tests pass

Diff Detail

Repository

Branch

5.0

Lint

Lint Skipped

Unit

Unit Tests Skipped

mwolff updated this revision to Diff 2407.Feb 20 2016, 10:46 PM

mwolff retitled this revision from to Use background priority for all clang parse threads..

mwolff updated this object.

mwolff edited the test plan for this revision. (Show Details)

mwolff added a reviewer: KDevelop.

Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptFeb 20 2016, 10:46 PM

mwolff added a project: KDevelop.Feb 20 2016, 10:46 PM

If I understand http://clang.llvm.org/doxygen/group__CINDEX.html#ga1b451634928d6bcc961bf72a40e4d035 correctly, then CXGlobalOpt_ThreadBackgroundPriorityForIndexing sounds like the more suitable flag for us...?

Would lead to:

background prio for indexing jobs
normal prio for jobs required by code completion

... iiuc.

This revision now requires changes to proceed.Feb 21 2016, 7:20 PM

Nice find nevertheless, never saw this libclang function!

attended kfunk's review

kfunk accepted this revision.Feb 21 2016, 10:29 PM

kfunk edited edge metadata.

This revision is now accepted and ready to land.Feb 21 2016, 10:29 PM

Closed by commit R32:ec3bcd1d40a8: Use background priority for clang parse threads. (authored by mwolff). · Explain WhyFeb 21 2016, 10:40 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			languages/clang/duchain/clangindex.cpp (5 lines)

Diff 2421

languages/clang/duchain/clangindex.cpp

Loading...