Differential D9963

[KCMShell] Don't assume KCModuleProxy is our child widget
ClosedPublic
Actions

Authored by broulik on Jan 18 2018, 3:27 PM.

Details

Reviewers
dfaure
davidedmundson
Commits
R126:25132c48039d: [KCMShell] Don't assume KCModuleProxy is our child widget
Summary

This broke with the introduction of scroll bars around the KCM as the widget is a QScrollArea nowadays.

Test Plan

Verified that activeModule isn't null anymore

Diff Detail

Repository
R126 KDE CLI Utilities
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jan 18 2018, 3:27 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 18 2018, 3:27 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jan 18 2018, 3:27 PM
davidedmundson accepted this revision.Jan 18 2018, 3:41 PM
This revision is now accepted and ready to land.Jan 18 2018, 3:41 PM
Closed by commit R126:25132c48039d: [KCMShell] Don't assume KCModuleProxy is our child widget (authored by broulik). · Explain WhyJan 19 2018, 9:18 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkcmshell/main.cpp (3 lines)

Diff 25627

View Options

kcmshell/main.cpp

Loading...