| mwolff |
| KDevelop |
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
It might have been better to split the changes.
On the other hand it seems nobody likes to spend much time on that plugin, so maybe doing it in one go is ok?
| plugins/subversion/svndiffjob.cpp | ||
|---|---|---|
| 342 | This one is called automatically and resulted in crashes. | |
| plugins/subversion/svnlogjob.cpp | ||
| 117 | Using a queued connection here, makes the notification for new log entries come too late. | |
I'm OK with this, but please split this up the next time. You could still have posted it as one review request, but splitting it up is always a good idea. It's a general coding mantra that you should start following, as it makes your life much easier in the long term.
| plugins/subversion/svnjobbase.cpp | ||
|---|---|---|
| 162 | not leaked when canceled? probably done from somewhere else? | |
Theoretically I'm aware of that and try to further improve concerning that matter... Thanks for the review.
| plugins/subversion/svnjobbase.cpp | ||
|---|---|---|
| 162 | The docs (and the code of KJob) say, that emitResult() calls deleteLater() by default, not depending on the status. | |