Set the focus to the active view, after leaving the terminal panel
ClosedPublic
Actions

Authored by adrianchavesfernandez on Jan 17 2018, 9:15 PM.

Details

Reviewers

emmanuelp
ngraham
elvisangelaccio

Group Reviewers

Dolphin

Commits

R318:4e40fe810d32: Set the focus to the active view, after leaving the terminal panel

Summary

BUG: 298467

Set the focus to the active view, after leaving the terminal panel.

This is a fork of the patch at https://git.reviewboard.kde.org/r/116118/ by @emmanuelp which should fix the issue with the original patch reported by Frank Reininghaus.

Test Plan

Works for me.

Diff Detail

Repository

R318 Dolphin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

adrianchavesfernandez requested review of this revision.Jan 17 2018, 9:15 PM

adrianchavesfernandez created this revision.

adrianchavesfernandez edited the summary of this revision. (Show Details)

ngraham edited the summary of this revision. (Show Details)Jan 17 2018, 9:18 PM

Thanks, this works great!

This revision is now accepted and ready to land.Jan 17 2018, 11:50 PM

Closed by commit R318:4e40fe810d32: Set the focus to the active view, after leaving the terminal panel (authored by Adrián Chaves Fernández (Gallaecio) <adriyetichaves@gmail.com>). · Explain WhyJan 18 2018, 5:52 PM

This revision was automatically updated to reflect the committed changes.

elvisangelaccio reopened this revision.Jan 18 2018, 7:11 PM

This revision is now accepted and ready to land.Jan 18 2018, 7:11 PM

This change broke the Windows CI: https://build.kde.org/job/Applications%20dolphin%20kf5-qt5%20WindowsMSVCQt5.9/52/

The TerminalPanel is not built on Windows, so we need something like: https://cgit.kde.org/dolphin.git/commit/?id=7787f080678ffd428b269acd8db370a8c0026b37

(even though we should really find a more robust solution, I'll open a task about this).

This revision now requires changes to proceed.Jan 18 2018, 7:12 PM

elvisangelaccio mentioned this in T7784: Fix TerminalPanel usage in dolphinmainwindow.Jan 18 2018, 7:17 PM

@elvisangelaccio I’ve just pushed a commit that comments the contents of the slot as seen in other places in the code. Can you please confirm that the change did the trick?

In D9955#192995, @adrianchavesfernandez wrote:

@elvisangelaccio I’ve just pushed a commit that comments the contents of the slot as seen in other places in the code. Can you please confirm that the change did the trick?

Yep it did, thanks.

elvisangelaccio accepted this revision.Jan 20 2018, 5:26 PM

This revision is now accepted and ready to land.Jan 20 2018, 5:26 PM

elvisangelaccio closed this revision.Jan 20 2018, 5:26 PM

Revision Contents
Changeset List

			Path	Packages
M			src/dolphinmainwindow.h (6 lines)
M			src/dolphinmainwindow.cpp (9 lines)
M			src/panels/terminal/terminalpanel.h (1 line)
M			src/panels/terminal/terminalpanel.cpp (11 lines)