Differential D9954

Ensure the database path exists before trying to create a file there
ClosedPublic
Actions

Authored by ahiemstra on Jan 17 2018, 7:30 PM.

Details

Reviewers
leinir
Commits
R157:a4134cce1e36: Ensure the database path exists before trying to create a file there
Summary

QStandardPath::writeableLocation can return a path that does not exist.
This causes QSql to complain that it cannot create the database. (with
the very unhelpful message "out of memory".) So ensure the path exists
before trying to open the database.

Diff Detail

Repository
R157 Peruse
Branch
fix_database_creation
Lint
No Linters Available
Unit
No Unit Test Coverage
ahiemstra requested review of this revision.Jan 17 2018, 7:30 PM
ahiemstra created this revision.
leinir accepted this revision.Jan 18 2018, 9:14 AM

Ah. Well spotted - and silly QStandardPaths ;)

This revision is now accepted and ready to land.Jan 18 2018, 9:14 AM
Closed by commit R157:a4134cce1e36: Ensure the database path exists before trying to create a file there (authored by ahiemstra). · Explain WhyJan 21 2018, 7:31 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/qtquick/BookDatabase.cpp (9 lines)

Diff 25559

View Options

src/qtquick/BookDatabase.cpp

Loading...