[KUserProxy] Adjust to accounts service
ClosedPublic

Authored by broulik on Jan 17 2018, 5:47 PM.

Details

Summary

The avatar can also lie in the accounts service directory. Monitor there and also monitor for removal.
Also in the handler check all paths we monitor rather than faceIconPath which might be empty due to the file having been removed.

BUG: 384107

Test Plan
  • Created an avatar, showed up in Kickoff right away
  • Deleted an avatar, default icon showed up in Kickoff right away

However, together with D9950 changing between avatars now throws

QML Image: Error decoding: file:///var/lib/AccountsService/icons/kaiuwe: This type of image is not supported

although I can open that file and it is a proper PNG file. Oh ffs.

Diff Detail

Repository
R296 KDeclarative
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jan 17 2018, 5:47 PM
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptJan 17 2018, 5:47 PM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jan 17 2018, 5:47 PM
broulik edited the test plan for this revision. (Show Details)
broulik edited the test plan for this revision. (Show Details)
apol added a subscriber: apol.Jan 18 2018, 3:27 AM

LGTM

src/qmlcontrols/kcoreaddons/kuserproxy.cpp
66

QLatin1Char('/')

davidedmundson accepted this revision.Jan 23 2018, 12:47 PM
davidedmundson added a subscriber: davidedmundson.

with Aleix's comment addressed in both places.
(or just put the slash on accountsServiceIconPath)

This revision is now accepted and ready to land.Jan 23 2018, 12:47 PM
This revision was automatically updated to reflect the committed changes.