[KUser] Check whether .face.icon is actually readable before returning it
ClosedPublic
Actions

Authored by broulik on Jan 17 2018, 5:42 PM.

Details

Reviewers

davidedmundson
apol

Group Reviewers

Frameworks

Commits

R244:e55d452031c2: [KUser] Check whether .face.icon is actually readable before returning it

Summary

Here .face.icon is a symlink to .face and when I remove my avatar in user manager, the .face is removed and .face.icon becomes a stale symlink.

Test Plan

Where is the bug? :)

Diff Detail

Repository

R244 KCoreAddons

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

broulik created this revision.Jan 17 2018, 5:42 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptJan 17 2018, 5:42 PM

broulik requested review of this revision.Jan 17 2018, 5:42 PM

ngraham added a subscriber: ngraham.Jan 17 2018, 5:43 PM

broulik mentioned this in D9951: [KUserProxy] Adjust to accounts service.Jan 17 2018, 5:47 PM

apol accepted this revision.Jan 18 2018, 3:29 AM

This revision is now accepted and ready to land.Jan 18 2018, 3:29 AM

Closed by commit R244:e55d452031c2: [KUser] Check whether .face.icon is actually readable before returning it (authored by broulik). · Explain WhyApr 24 2018, 9:09 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/lib/util/kuser_unix.cpp (3 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	25550			Jan 17 2018, 5:40 PM	★	★
Diff 2	33016	51b66d2	R244:e55d452031c2822ed4b0d271cd350bed44c87188	Apr 24 2018, 9:08 PM	★	★

Diff 33016

View Options

src/lib/util/kuser_unix.cpp