expose in the libinput wrapper a property that tells whether
a tablet mode switch input device is present on the machine,
expose it trough dbus
Details
Details
- Reviewers
graesslin - Group Reviewers
KWin Plasma - Commits
- R108:87b688daae7a: Expose if the tablet mode switch is available
still not complete, I need a way to either access the connection
from TabletModeManager or setting to TabletModeManager from input.cpp
Diff Detail
Diff Detail
- Repository
- R108 KWin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
In terms of goals, is this interface:
- about exposing the raw switch data that we have from libinput
- trying to be a canonical source of what mode a device is in from all information available (which currently happens to be the libinput switch)
Comment Actions
api-wise on the dbus side, could also be done that the interface being there means the switch is possible, otherwise doesn't get registered/destroyed
| tabletmodemanager.cpp | ||
|---|---|---|
| 94 | Impossible! That's violating the layering. KWin core does not depend or interact with libinput for our overall sanity. | |
| tabletmodemanager.cpp | ||
|---|---|---|
| 94 | I tought as much, but would be possible then to expose the property in an abstract way from the core for this to read? | |
| tabletmodemanager.cpp | ||
|---|---|---|
| 94 | which, would make sense api-wise even if something different than libinput was used underneath | |
| tabletmodemanager.cpp | ||
|---|---|---|
| 94 | makes sense. VirtualKeyboard also accesses the information through input | |
| tabletmodemanager.cpp | ||
|---|---|---|
| 94 | ok, i'll try to add an api for that in thir rr then | |
| input.cpp | ||
|---|---|---|
| 1897 | false | |
| tabletmodemanager.cpp | ||
|---|---|---|
| 87–96 | is this method still needed? | |
| tabletmodemanager.cpp | ||
|---|---|---|
| 87–96 | yes, the point is to expose it to applications (on plasma i wouldn't want a "show this only in tablet mode" option visible (or at least, enabled) if the hardware doesn't support tablet mode at all | |
| tabletmodemanager.cpp | ||
|---|---|---|
| 87–96 | I meant the method setTabletModeAvailable, your reply seems to be for isTabletModeAvailable? | |
| tabletmodemanager.cpp | ||
|---|---|---|
| 87–96 | sorry, i misunderstood, indeed that's not needed anymore, removing | |