Differential D9940

Fix memory management for internal Completer of the combo box editor (when extraValueAllowed=true)
ClosedPublic
Actions

Authored by staniek on Jan 17 2018, 9:04 AM.

Details

Reviewers
piggz
Commits
R13:51508886d9c6: Fix memory management for internal Completer of the combo box editor (when…
Summary
  • Fix memory management
  • Add a property with extraValueAllowed=true for the example app

FIXED-IN:3.1.0

Test Plan

Try List, List 2 and Editable List properties of the kpropertyexample app.
Try e.g. data source property for elements in KEXI reports or KReportExample

Diff Detail

Repository
R13 KProperty
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
staniek created this revision.Jan 17 2018, 9:04 AM
Restricted Application added a project: KProperty. · View Herald TranscriptJan 17 2018, 9:04 AM
staniek requested review of this revision.Jan 17 2018, 9:04 AM
staniek edited the summary of this revision. (Show Details)Jan 17 2018, 9:23 AM
piggz added a comment.Jan 19 2018, 5:46 PM

Just to confirm the existence of the completer doesnt prevent manual entry?

staniek added a comment.Jan 19 2018, 6:15 PM

@piggz No, it's in-line completer:

piggz accepted this revision.Jan 19 2018, 7:48 PM
This revision is now accepted and ready to land.Jan 19 2018, 7:48 PM
Closed by commit R13:51508886d9c6: Fix memory management for internal Completer of the combo box editor (when… (authored by staniek). · Explain WhyJan 19 2018, 9:18 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mexamples/window.cpp (21 lines)
Msrc/editors/combobox.cpp (21 lines)

Diff 25527

View Options

examples/window.cpp

Loading...
View Options

src/editors/combobox.cpp

Loading...