Differential D9922

Unbreak the GDB QUrl pretty printer test
ClosedPublic
Actions

Authored by mwolff on Jan 16 2018, 1:26 PM.

Details

Reviewers
kfunk
Group Reviewers
KDevelop
Commits
R32:eeb8c640deb5: Unbreak the GDB QUrl pretty printer test
R32:a2a4632e9401: Unbreak the GDB QUrl pretty printer test
Summary

By changing the test client back to what it expects. Blindly also
adapt the LLDB test which introduced the regression in the first
place. Note that I cannot run the LLDB test locally, so I'm not
sure whether the test passes there.

Still, don't break GDB tests, people are using those...

Diff Detail

Repository
R32 KDevelop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mwolff created this revision.Jan 16 2018, 1:26 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptJan 16 2018, 1:26 PM
mwolff requested review of this revision.Jan 16 2018, 1:26 PM
kfunk accepted this revision.Jan 16 2018, 1:40 PM
This revision is now accepted and ready to land.Jan 16 2018, 1:40 PM
Closed by commit R32:eeb8c640deb5: Unbreak the GDB QUrl pretty printer test (authored by mwolff). · Explain WhyJan 16 2018, 2:13 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 25471

View Options

plugins/debuggercommon/tests/debuggees/qurl.cpp

Loading...
View Options

plugins/lldb/unittests/test_lldbformatters.cpp

Loading...