Differential D9911

Folderspanel's context-menu option "Limit to Home Directory" is always visible
ClosedPublic
Actions

Authored by michaelh on Jan 16 2018, 9:34 AM.

Details

Reviewers
ngraham
elvisangelaccio
Group Reviewers
Dolphin
Commits
R318:64d2fd29819f: Folderspanel's context-menu option "Limit to Home Directory" is always visible
Summary

Applied suggested changes to D9662

  • Enum instead of bool
  • Use QStringLiteral
Test Plan

Visual inspection

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
michaelh created this revision.Jan 16 2018, 9:34 AM
Restricted Application added a subscriber: Dolphin. · View Herald TranscriptJan 16 2018, 9:34 AM
michaelh requested review of this revision.Jan 16 2018, 9:34 AM
michaelh added inline comments.Jan 16 2018, 9:42 AM
src/panels/folders/folderspanel.h
93

Are the comments just noise?

99

I wanted to

* @param navigationBehaviour \see NavigationBehaviour

but KDevelop kept complaining

ngraham accepted this revision.Jan 18 2018, 12:12 AM

Looks good to me.

src/panels/folders/folderspanel.h
93

I don't mind them, but then again I usually prefer more verbosity to less.

This revision is now accepted and ready to land.Jan 18 2018, 12:12 AM
Closed by commit R318:64d2fd29819f: Folderspanel's context-menu option "Limit to Home Directory" is always visible (authored by michaelh). · Explain WhyJan 18 2018, 8:11 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 25574

View Options

src/panels/folders/folderspanel.h

Loading...
View Options

src/panels/folders/folderspanel.cpp

Loading...