Differential D989

Don't update size when minimum size changes while animation is running
ClosedPublic
Actions

Authored by drosca on Feb 18 2016, 9:11 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R119:6ba90e0467d8: Don't update size when minimum size changes while animation is running
Summary

Changing the width/height while animation on width/height is running
will cancel it. This fixes bug with applet being moved on top of another
applet when move operation results in animation that changes the applet's
position and size.

+ small cleanup: width/height animation "to" is always 0

no need to twice calculate grid position for positionItem()

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
drosca updated this revision to Diff 2395.Feb 18 2016, 9:11 PM
drosca retitled this revision from to Don't update size when minimum size changes while animation is running.
drosca updated this object.
drosca edited the test plan for this revision. (Show Details)
drosca added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 18 2016, 9:11 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Aug 28 2016, 1:07 PM
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.Aug 28 2016, 1:07 PM
Closed by commit R119:6ba90e0467d8: Don't update size when minimum size changes while animation is running (authored by drosca). · Explain WhyAug 28 2016, 3:05 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 6338

View Options

containments/desktop/package/contents/ui/AppletAppearance.qml

Loading...
View Options

containments/desktop/package/contents/ui/AppletHandle.qml

Loading...