[13:35] <milian> how the hell can kdesu ever work? https://phabricator.kde.org/D9888 WTF
[13:35] <milian> does anyone know if I'm missing something?
[13:35] <milian> googling for these macros doesn't show me anything obvious either
[13:53] <sitter> milian: dead code I'd say. note the `if` following your change checks if the file 'false' is exectuable (which it isn't as that'd be ./false which likely never exists) and then falls back to QSP::findExec(cmd). where cmd is macro'd to sudo or su depending on the cmake switch KDESU_USE_SUDO_DEFAULT
[13:54] <milian> but it doesn't work for me without this patch
[13:54] <milian> so it cannot be dead code :D
[13:55] <milian> i.e. how can this work for anyone right now?
[13:58] <sitter> milian: http://paste.debian.net/1005279/ is how I read the original
[13:59] <milian> I'll see why this does not happen on my system
[14:02] <sitter> milian: try this for good measure http://paste.debian.net/1005280/
[14:02] <milian> yep
[14:03] <sitter> mind you, it could be that __PATH_SU/SUDO is actually defined somewhere in a system level include which would then make the QT_ACCESS pass and break things
[14:03] <milian> I can't find it in my  /usr/include at least
[14:06] <milian> sitter: QT_ACCESS("false", X_OK) == 0 on my system
[14:07] <milian> and no, there's no false in the current PWD
[14:07] <milian> it's in /usr/bin though
[14:07] <milian> I'd also be OK with removing that whole code and simplifying it
[14:08] <milian> like you proposed
[14:08] <sitter> something is wrong with your libc :P
[14:09] <sitter> https://linux.die.net/man/2/faccessat
[14:09] <sitter> "If the pathname given in pathname is relative, then it is interpreted relative to the directory referred to by the file descriptor dirfd (rather than relative to the current working directory of the calling process, as is done by access(2) for a relative pathname)."
[14:10] <milian> ah wait, the pwd _is_ /usr/bin inmy test
[14:10] <sitter> :)
[14:10] <milian> ah yes, now I see why, too
[14:10] <milian> (hotspot defaults to the test binaries origin, which for /usr/bin/ls is... /usr/bin - doh)
[14:10] <milian> still, breaking kdesu when PWD == /usr/bin makes no sense