core, add subLevelText alias in Score.qml
ClosedPublic

Authored by asagtani on Jan 12 2018, 9:10 AM.

Details

Reviewers
jjazeix
Group Reviewers
GCompris
Summary

Created a new alias for subLevelText to access its properties like regularSize, tinySize, largeSize, etc for fontSize in activities directly.

By help of it these properties can be accessed directly, for eg -->

Score {

fontSize: subLevelText.regularSize

}

Diff Detail

Repository
R2 GCompris
Lint
Lint Skipped
Unit
Unit Tests Skipped
asagtani created this revision.Jan 12 2018, 9:10 AM
Restricted Application added a project: KDE Edu. · View Herald TranscriptJan 12 2018, 9:10 AM
Restricted Application added a subscriber: KDE Edu. · View Herald Transcript
asagtani requested review of this revision.Jan 12 2018, 9:10 AM
asagtani updated this revision to Diff 25205.
jjazeix accepted this revision.Jan 13 2018, 8:54 PM

Once fixed, you can commit directly on master.

Thank you

src/core/Score.qml
74

As it should only be used for setting the font size, I would rename the alias for external reference. Something like internalTextComponent, to insist on the fact it should be used carefully.
Is it possible to make it readonly?

This revision is now accepted and ready to land.Jan 13 2018, 8:54 PM
asagtani closed this revision.Jan 14 2018, 9:41 AM

committed to master.