Details
- Reviewers
elvisangelaccio - Group Reviewers
Dolphin - Commits
- R318:c5eb4e31161c: Use BatchRenameJob to rename multiple files in Dolphin
Diff Detail
- Repository
- R318 Dolphin
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage
| src/views/renamedialog.cpp | ||
|---|---|---|
| 168 | KFileItemList has a urlList() method that does that | |
| 174 | Do we need QUrl::StripTrailingSlash here? At least most other places in KIO that use RemoveFileName set it | |
| 179 | The job is async, so by the time you end up here the job hasn't even started yet, your handling should be in slotFileRenamed or rather connect to result signal? | |
| src/views/renamedialog.cpp | ||
|---|---|---|
| 174 | When undoing BatchRename parentUrl is not used. So IMO setting QUrl::StripTrailingSlash won't make any difference. | |
Nice. Tested, and it works as expected, including undo, as advertised. So that's nice. +1 from me, but I'll wait for someone more experienced to do a code review.
Looks good, but please bump the minimum KF5 version in CMakeLists.txt to 5.42
| src/views/renamedialog.cpp | ||
|---|---|---|
| 204–205 | Nitpick, semicolon not necessary. | |
@chinmoyr Friendly ping! If we can get this in before tomorrow, I'll be able to highlight it in my weekly Usability and Productivity status report. :)