Bump min cmake version to 3.0
ClosedPublic

Authored by kossebau on Jan 12 2018, 6:07 AM.

Details

Summary

The required KF5 dependencies already need cmake 3.0, so a system where KF5
can be build has to have cmake 3.0 around, and there is no reason to still allow
older cmake with Plasma Workspace.

Allows to drop ECMPackageConfigHelpers for CMakePackageConfigHelpers
(which was included unconditionally before, so already created
informal dep on cmake 3.0)

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.Jan 12 2018, 6:07 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 12 2018, 6:07 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
kossebau requested review of this revision.Jan 12 2018, 6:07 AM

Similar fixes could be done to the other Plasma repos. Would care myself for kdeplasma-addons, as I have a build setup for that as well, so can test.

CMakeLists.txt
11

Ops, that slipped in. But might make sense to do as separate commit as well, given ECM is now even officially part of KF5.

kossebau edited the summary of this revision. (Show Details)Jan 12 2018, 6:10 AM
kossebau added a subscriber: hein.Jan 12 2018, 6:16 AM
kossebau added inline comments.
libtaskmanager/CMakeLists.txt
99 ↗(On Diff #25197)

@hein BTW, that LibTaskManagerConfig.cmake misses some find_dependency()s (+include(CMakeFindDependencyMacro) after this patch) for all the libs in the public interface.
Sadly cmake does not generate that itself, so one has to manually note them.
Similar possibly for the other installed cmake config files.

Cmp. e.g.
https://phabricator.kde.org/source/plasma-framework/browse/master/KF5PlasmaConfig.cmake.in;fab4cdd95b7ceb4e608f8e4368682fe0a589ccff$17

davidedmundson accepted this revision.Jan 31 2018, 11:53 AM
davidedmundson added a subscriber: davidedmundson.

Please verify our CI has 3.0 first.

This revision is now accepted and ready to land.Jan 31 2018, 11:53 AM
This revision was automatically updated to reflect the committed changes.