Differential D9813

[Kicker] Also round to icon size custom square images
ClosedPublic
Actions

Authored by broulik on Jan 11 2018, 9:41 AM.

Details

Reviewers
hein
mart
Group Reviewers
Plasma
Commits
R119:ae219e8941cb: [Kicker] Also round to icon size custom square images
Summary

When a custom square image is set, we can assume it's meant to be an icon. Also round it to icon sizes to avoid scaling artefacts.

Test Plan

Needs D9812 to work

Set a square custom icon, it was scaling in steps as I resized my panel just as a non-custom icon would. Custom non-square icons are unaffected.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jan 11 2018, 9:41 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 11 2018, 9:41 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jan 11 2018, 9:41 AM
mart accepted this revision.Jan 12 2018, 3:28 PM
This revision is now accepted and ready to land.Jan 12 2018, 3:28 PM
hein accepted this revision.Jan 15 2018, 9:16 AM
Closed by commit R119:ae219e8941cb: [Kicker] Also round to icon size custom square images (authored by broulik). · Explain WhyJan 15 2018, 9:24 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 25374

View Options

applets/kicker/package/contents/ui/CompactRepresentation.qml

Loading...