Show error message to the user
ClosedPublic

Authored by schwarzer on Jan 10 2018, 9:24 PM.

Details

Summary

When no tilesets or backgrounds were found, KShisen just started with a blank field. Now the user is shown a message explaining what happened.

I also want to try and check for this with CMake but since I need to look into that further, I wanted at least the error message in place.

Comments?

Diff Detail

Repository
R412 KShisen
Lint
Lint Skipped
Unit
Unit Tests Skipped
schwarzer requested review of this revision.Jan 10 2018, 9:24 PM
schwarzer created this revision.
aacid added a subscriber: aacid.Jan 10 2018, 9:57 PM

Is phabricator being silly or are your patches missing some stuff?

Like it says
...\nPlease install the
and ends there

In D9805#189130, @aacid wrote:

Is phabricator being silly or are your patches missing some stuff?

Like it says
...\nPlease install the
and ends there

Meh, my diff has those in the next line. The line ends " KMahjongg library.", Prefs::tileSet()));"

schwarzer updated this revision to Diff 25132.Jan 10 2018, 10:10 PM

fix diff ... hopefully

I just realzied this is not how you use QMEsasgebox critical.

Since it's static you just do QMessageBox::critical(...)

Second one should be Prefs::background and not Prefs::tileSet?

In D9805#189154, @aacid wrote:

I just realzied this is not how you use QMEsasgebox critical.

Since it's static you just do QMessageBox::critical(...)

Thanks for pointing that out.

Second one should be Prefs::background and not Prefs::tileSet?

Of course. Copy&Paste error. -_-

Thanks for the review. I will upload an updated patch tomorrow. :)

schwarzer updated this revision to Diff 25181.Jan 11 2018, 6:49 PM
schwarzer updated this revision to Diff 25182.
aacid accepted this revision.Jan 11 2018, 7:15 PM
This revision is now accepted and ready to land.Jan 11 2018, 7:15 PM
This revision was automatically updated to reflect the committed changes.