Apply some C++11 niceties, styling consistency
ClosedPublic
Actions

Authored by Kanedias on Jan 10 2018, 8:56 PM.

Details

Reviewers

Commits

Summary

I've noticed some override statements in the code, so I think
it may be safely assumed that we're at least compiling in C++11
mode.

Fixed override/nullptr/default usages, fixed some spacing
style problems

Repository

R858 Qt Quick Controls 2: Desktop Style

Branch

c++11

Lint

No Linters Available

Unit

No Unit Test Coverage

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

Kanedias requested review of this revision.Jan 10 2018, 8:56 PM

Apply some C++11 niceties, styling consistency

apol added inline comments.

kirigami-plasmadesktop-integration/plasmadesktoptheme.cpp
234–235	if you make it `auto` the initializer_list will be used not requiring the allocation AFAIU. That said, I wonder if the compiler can unwind a foreach.

kirigami-plasmadesktop-integration/plasmadesktoptheme.cpp
234–235	I didn't quite get it, you mean we can write `for (auto state : { QPalette::Active, QPalette::Inactive, QPalette::Disabled })` to get rid of allocation of `states` array?

kirigami-plasmadesktop-integration/plasmadesktoptheme.cpp
234–235	Yes, or `static const auto states = { QPalette::Active, QPalette::Inactive, QPalette::Disabled };` Shouldn't be much of a difference.

Fix palette array allocation

Kanedias marked 3 inline comments as done.Jan 12 2018, 6:59 AM

Will update this today with changes from caching by Alex

Rebased

This revision is now accepted and ready to land.Jan 14 2018, 4:00 PM

			Path	Packages
M			kirigami-plasmadesktop-integration/kirigamiplasmafactory.h (2 lines)
M			kirigami-plasmadesktop-integration/kirigamiplasmafactory.cpp (4 lines)
M			kirigami-plasmadesktop-integration/plasmadesktoptheme.h (4 lines)
M			kirigami-plasmadesktop-integration/plasmadesktoptheme.cpp (31 lines)
M			plugin/CMakeLists.txt (2 lines)
M			plugin/kquickpadding_p.h (2 lines)
M			plugin/kquickstyleitem.cpp (64 lines)
M			plugin/kquickstyleitem_p.h (12 lines)
M			plugin/qqc2desktopstyleplugin.h (2 lines)
M			plugin/qsgdefaultninepatchnode_p.h (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	25122	3a3a822		Jan 10 2018, 8:56 PM	★	★
Diff 2	25123	3a3a822	Apply some C++11 niceties, styling consistency	Jan 10 2018, 8:59 PM	★	★
Diff 3	25198	3a3a822	Fix palette array allocation	Jan 12 2018, 6:58 AM	★	★
Diff 4	25244	d3ae930	Rebased	Jan 12 2018, 6:08 PM	★	★