[Panel View] Check if it's the same applet we're configuring before just hiding current view
ClosedPublic

Authored by broulik on Jan 10 2018, 6:34 PM.

Details

Summary

This fixes opening panel controller while an applet config dialog was open.
It would find that we want to show config for a panel but find a config is already open, so it would just close it, even though it was not the panel controller (which should be toggleable) but another applet config.
While at it restructure if statements a bit.

Test Plan
  • Opening panel controller still works
  • Closing panel controller when open (toggle) still works
  • Opening applet config with panel controller open closes panel controller and opens applet dialog
  • Opening panel controller with applet config open now closes applet dialog and then opens panel controller ← this was buggy
  • Opening another applet config still closes current applet config and opens new one

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jan 10 2018, 6:34 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 10 2018, 6:34 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jan 10 2018, 6:34 PM
mart accepted this revision.Jan 12 2018, 3:31 PM
This revision is now accepted and ready to land.Jan 12 2018, 3:31 PM
This revision was automatically updated to reflect the committed changes.