Differential D9787

[Theme Explorer] Use theme name instead of ID in theme dropdown
ClosedPublic
Actions

Authored by broulik on Jan 10 2018, 10:47 AM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R118:f786132a2f64: [Theme Explorer] Use theme name instead of ID in theme dropdown
Summary

Shows "Breeze" and "Breeze Dark" instead of "default" and "breeze-dark" in the list

Test Plan

I thought "display" was in there as role by default but apparently it's not

Diff Detail

Repository
R118 Plasma SDK
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jan 10 2018, 10:47 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 10 2018, 10:47 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jan 10 2018, 10:47 AM
broulik retitled this revision from [Theme Explorer] Use theme name instead of ID to [Theme Explorer] Use theme name instead of ID in theme dropdown.Jan 10 2018, 11:54 AM
davidedmundson accepted this revision.Jan 10 2018, 1:10 PM
This revision is now accepted and ready to land.Jan 10 2018, 1:10 PM
Closed by commit R118:f786132a2f64: [Theme Explorer] Use theme name instead of ID in theme dropdown (authored by broulik). · Explain WhyJan 10 2018, 5:13 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 25101

View Options

themeexplorer/package/contents/ui/main.qml

Loading...
View Options

themeexplorer/src/themelistmodel.cpp

Loading...