do not incorrectly split spaces in paths of duplicate results
ClosedPublic

Authored by sitter on Jan 10 2018, 9:33 AM.

Details

Summary

use kcoreaddons to split fdupes output. fdupes outputs
/space\ inbetween/x.svg /space\ inbetween/y.svg
as dupe result, which, if we split blindly for space, we'll split into 4
pieces instead of 2.
splitting the argument string using escape rules via kshell gives us
correct splitting by taking into account the escaped spaces.

unfortunately qregex doesn't seem to support negative lookbehind
expressions, or we could solve this with a (?<!\\\\) instead of having
to use kshell.

Test Plan

test output is lovely again

Diff Detail

Repository
R266 Breeze Icons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.Jan 10 2018, 9:33 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 10 2018, 9:33 AM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
sitter requested review of this revision.Jan 10 2018, 9:33 AM
apol accepted this revision.Jan 10 2018, 2:58 PM
This revision is now accepted and ready to land.Jan 10 2018, 2:58 PM
This revision was automatically updated to reflect the committed changes.
cfeck added a subscriber: cfeck.Jan 10 2018, 7:45 PM

CI doesn't like Tier1 frameworks have a dependency on other Tier1 frameworks.

I don't either ;)

I'll fix this with a micro-handmade-state-machine, I like those.

https://phabricator.kde.org/D9807 (to be applied after reverting this commit)