Use 1px padding on titlebuttons
ClosedPublic

Authored by tomanderson on Jan 9 2018, 8:06 PM.

Details

Summary

This patch fixes titlebutton rendering in Chromium. The headerbar used by Breeze is the same size when a window is maximized, but Chromium uses a smaller headerbar for its tabstrip background when the browser is maximized. When buttons won't fit, Chromium downsizes buttons. This was happening with Breeze titlebuttons since it used 6px of padding on the top and bottom of the buttons, so the buttons appeared taller than they actually were. This patch changes the top and bottom padding to 1px. In native GTK apps, there's no change in appearance.

Diff Detail

Repository
R98 Breeze for Gtk
Lint
Lint Skipped
Unit
Unit Tests Skipped
tomanderson created this revision.Jan 9 2018, 8:06 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 9 2018, 8:06 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
tomanderson requested review of this revision.Jan 9 2018, 8:06 PM
abetts accepted this revision.Jan 9 2018, 9:11 PM
This revision is now accepted and ready to land.Jan 9 2018, 9:11 PM

Thanks Andres. Could you also merge this CL for me? I don't have write permissions for the repo.

Thanks Andres. Could you also merge this CL for me? I don't have write permissions for the repo.

Hey Tom,

Thanks for the comment. I will leave this to the dev team. My vote was as support for this visual change as I am part of the Visual Design Group. The dev team will also review and push the revision upstream if they determine that it is a sensible change.

This revision was automatically updated to reflect the committed changes.

Looks like this fixed everything but the maximize button: https://bugs.kde.org/show_bug.cgi?id=391232