Use at least the requested width for the argument hint tree
AbandonedPublic

Authored by mwolff on Jan 9 2018, 4:12 PM.

Details

Summary

This ensures the code completion tree and the argument hint tree have
the same width in the usual case. In abnormal cases the argument hint
tree could become larger, but in practice this doesn't happen as most
hints are also valid completion items in turn, thus show up there
too and are properly accounted for in the requested width.

Additionally ensure the geomtries stay in sync, when the completion
list is moved or resized.

Without this patch, the argument hint list is often narrower than the
completion list, which looks odd I think.

Diff Detail

Repository
R39 KTextEditor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mwolff created this revision.Jan 9 2018, 4:12 PM
Restricted Application added projects: Kate, Frameworks. · View Herald TranscriptJan 9 2018, 4:12 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
mwolff requested review of this revision.Jan 9 2018, 4:12 PM
mwolff added a subscriber: kfunk.Jan 16 2018, 9:02 AM

ping? @kfunk maybe?

I would prefer if you commit this soon, since then we still have 3 weeks for testing.
To me this look ok, but I cannot say whether there are side-effects or not.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 16 2018, 2:15 PM
This revision was automatically updated to reflect the committed changes.
kfunk reopened this revision.Jan 16 2018, 2:51 PM

LGTM.

Just a had a quick look at the appearance of the popup before vs. after the patch when doing code completion inside the a function call parameter list. Looks more consisten now, thanks!

mwolff abandoned this revision.Jan 18 2018, 10:29 AM

this was comitted already, closing it again

Whoops. Sorry for accidentally reopening it to begin with.