Differential D9765

Increase timeout for notification disconnected/connected notification
ClosedPublic
Actions

Authored by broulik on Jan 9 2018, 4:09 PM.

Details

Reviewers
jgrulich
Group Reviewers
Plasma
Commits
R116:cfe45d03e07f: Increase timeout for notification disconnected/connected notification
Summary

Network Manager nowadays takes forever to reconnect to a network, so the 5 seconds that used to work fine, are no longer sufficient.

Test Plan

I no longer get a notification about being connected to Wifi on resume

Diff Detail

Repository
R116 Plasma Network Management Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jan 9 2018, 4:09 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 9 2018, 4:09 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jan 9 2018, 4:09 PM
broulik added a comment.Jan 9 2018, 4:14 PM

We could also split it and keep the 5 seconds till "you are no longer connected" (when we don't have an active or activating connection, it usually still sees the network quickly) and then only after 10 or 15 seconds clear the "connection before suspend" list

jgrulich accepted this revision.Jan 10 2018, 6:13 AM

I think that even 10 seconds is just fine for showing that you are no longer connected.

This revision is now accepted and ready to land.Jan 10 2018, 6:13 AM
Closed by commit R116:cfe45d03e07f: Increase timeout for notification disconnected/connected notification (authored by broulik). · Explain WhyJan 10 2018, 9:09 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mkded/notification.cpp (2 lines)

Diff 25056

View Options

kded/notification.cpp

Loading...