Differential D9763

[Slideshow] Don't repeatedly restart on startup
ClosedPublic
Actions

Authored by broulik on Jan 9 2018, 1:44 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R120:140a1bc2b768: [Slideshow] Don't repeatedly restart on startup
Summary

Wait for m_ready until doing anything. This keeps the slideshow from first showing the default wallpaper, then a random slideshow image, and then fade to the next slideshow image.

Test Plan
  • Switching slideshow wallpapers is still animated
  • clicking "Next wallpaper" in context menu still works
  • Copying a file to the picture folder will add it to the slideshow just fine

Removed the setSingleImage() call in the constructor which would never do anything as it's guarded by m_ready

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jan 9 2018, 1:44 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 9 2018, 1:44 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jan 9 2018, 1:44 PM
davidedmundson accepted this revision.Jan 9 2018, 1:48 PM
davidedmundson added a subscriber: davidedmundson.
davidedmundson added inline comments.
wallpapers/image/image.cpp
147–149

probably don't need that timer now, it looks like an attempt at what you're doing with the parser status.

This revision is now accepted and ready to land.Jan 9 2018, 1:48 PM
Closed by commit R120:140a1bc2b768: [Slideshow] Don't repeatedly restart on startup (authored by broulik). · Explain WhyJan 10 2018, 5:27 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mwallpapers/image/image.cpp (12 lines)

Diff 25107

View Options

wallpapers/image/image.cpp

Loading...