Differential D9762

[Image Wallpaper] Just use Timer to determin when we're ready
ClosedPublic
Actions

Authored by broulik on Jan 9 2018, 1:37 PM.

Details

Reviewers
None
Group Reviewers
Plasma
Commits
R120:87ec46be03b4: [Image Wallpaper] Just use Timer to determin when we're ready
Summary

This avoids fading the image source, or the fill mode, or the source size on startup while we're still setting things up.
While a Timer is usually a bad idea, this simplifies the code a lot.

Test Plan

Trust me, I've been trying to come up with a solution for it needlessly fading things on startup for weeks. Either this or we'll leave it broken..

  • Started plasmashell, image wallpaper was there instantly rather than having it fade in.
  • Changing image or fill mode or resizing plasmoidviewer still animates nicely
  • Slideshow image still transitions

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jan 9 2018, 1:37 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 9 2018, 1:37 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jan 9 2018, 1:37 PM
broulik edited the test plan for this revision. (Show Details)
davidedmundson added a subscriber: davidedmundson.Jan 9 2018, 1:45 PM

Meh. If there's nothing by 5.12.0 push it, but hopefully we can get something better by then.

At a glance, I'd assume it's failing because onFillModelChanged and onModelChanged are both called during startup resulting in the second one doing a fade?

wallpapers/image/imagepackage/contents/ui/main.qml
109

why are you removing this check?

broulik updated this revision to Diff 25235.Jan 12 2018, 2:29 PM

Restore source size check before fading it

This revision was not accepted when it landed; it landed in state Needs Review.Jan 15 2018, 10:07 AM
Closed by commit R120:87ec46be03b4: [Image Wallpaper] Just use Timer to determin when we're ready (authored by broulik). · Explain Why
This revision was automatically updated to reflect the committed changes.
bicakci added a subscriber: bicakci.Feb 17 2019, 5:05 PM

Hello!

This commit causes a regression on my system. [1] In summary, during plasma's start-up the desktop background/wallpaper is initially displayed, but as soon as kscreen sets up the displays there are a number of flickers and the wallpaper is replaced with black background. I can reproduce this issue relatively reliably with compositing switched off.

I was able to resolve this issue locally by reverting this commit on my system, and I verified that the reverted commit resolves the aforementioned regression. I found this commit by inspecting the git history.

Would it be possible to revert and/or rework this commit?

Thank you!

[1] An x86_64 laptop with an up-to-date version of Kubuntu 18.04 with plasma-workspace 5.12.7, connected to an external display using HDMI.

Revision Contents
Changeset List

Diff 25379

View Options

wallpapers/image/imagepackage/contents/ui/main.qml

Loading...