Differential D9753

Win: Create local socket named pipes based on the instalaltion prefix
ClosedPublic
Actions

Authored by vonreth on Jan 9 2018, 8:52 AM.

Details

Reviewers
dfaure
dvratil
Commits
R165:31d35585ff10: Win: Create local socket named pipes based on the instalaltion prefix
Summary

This allows multiple paralell akonadi installations running without
clashing.

Diff Detail

Repository
R165 Akonadi
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
vonreth created this revision.Jan 9 2018, 8:52 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptJan 9 2018, 8:52 AM
Restricted Application added a subscriber: KDE PIM. · View Herald Transcript
vonreth requested review of this revision.Jan 9 2018, 8:52 AM
vonreth added reviewers: dfaure, dvratil.Jan 9 2018, 8:54 AM
vonreth added subscribers: Windows, kfunk.
dvratil added a comment.Jan 9 2018, 9:57 AM

Thinking about this, will this work if the actual application is installed in a different prefix than the Akonadi server/libraries?

vonreth added a comment.Jan 9 2018, 10:19 AM
In D9753#188060, @dvratil wrote:

Thinking about this, will this work if the actual application is installed in a different prefix than the Akonadi server/libraries?

In that case most probably everything, including akonadi, would break.
The only valid setup, with the applications using akonadi in a different prefix, that I can imagine are unit tests....
So as te client dll is lokated besides the akonadi server maybe we should use the dir of the dll in the client side code?

dvratil accepted this revision.Jan 9 2018, 10:29 AM

Unit-tests are not a concern, we can export the environment variables there to set the correct pipe name.

If running the app from another prefix than Akonadi is not a reasonable usecase, then we are good :-) Thanks!

This revision is now accepted and ready to land.Jan 9 2018, 10:29 AM
Closed by commit R165:31d35585ff10: Win: Create local socket named pipes based on the instalaltion prefix (authored by vonreth). · Explain WhyJan 9 2018, 10:42 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/core/connection.cpp (14 lines)
Msrc/server/akonadi.cpp (44 lines)

Diff 24996

View Options

src/core/connection.cpp

Loading...
View Options

src/server/akonadi.cpp

Loading...