Add progress loading icon to QtQuick server row
ClosedPublic
Actions

Authored by Kanedias on Jan 7 2018, 1:45 PM.

Details

Reviewers

Commits

R7:07af02c1cfce: Add progress loading icon to QtQuick server row

Summary

This adds loading icon in the same place where unread notification count
resides. These two will never interfer with each other because loading
is always finished when unread count is displayed.

Connection state enum had to be moved from namespace to Server class
because of QML support: QML only supports "nested" class enums or
namespace enums of new C++11 style (enum classes). Signals and typos
were transformed to new syntax and fixed along the way.

There are still some quirks that I'm unsure how to fix:

Loading icon is pixelated when it rotates - strange given it's SVG
Loading icon appears smoothly but disappears instantaneously because of QML destroy() behaviour.

Diff Detail

Repository

R7 Konversation

Branch

busy-indicator

Lint

Lint OK

Unit

No Unit Test Coverage

Kanedias requested review of this revision.Jan 7 2018, 1:45 PM

Kanedias created this revision.

Nice idea!

I think from an API perspective it'd be nicer to expose the enum to Qt Quick via a ConnectionState uninstantiable class though, then it'd be used in QML via e.g. Konversation.ConnectionState.SSConnected.

I wish I could remember why it has those SS prefixes - might be nice to just drop them for QML. Konversation.ConnectionState.Connected reads very nice IMHO.

Hi Eike!

Marco proposed to push this style of BusyIndicator further to qqc2-desktop-integration, I'll update this revision once I'm done there.
And yes, I'll update enum accordingly, thanks :)

Kanedias mentioned this in D1230: GBM remote access support for KWin.Jan 17 2018, 6:01 PM

Add namespace-level enum, fixes for Eike comments

@hein , I managed to do this! Via namespace-level enums

Some notes:

I upstreamed QQC2.BusyIndicator style to qqc2-desktop-style master
By my experience (and according to Martin) qqc2-desktop-style should be installed to /usr to be actually usable by applications, my other attempts failed
Hope you don't mind some cleanups and comments where code flow seemed difficult

Kanedias added a dependency: D9804: Add BusyIndicator to the styled controls list.Jan 17 2018, 10:13 PM

Let's nix the console.log() calls (unlike qDebug those don't go no-op in a rlease build), otherwise looks ready to go. Great work!

This revision is now accepted and ready to land.Jan 18 2018, 10:00 AM

Kanedias closed this revision.Jan 18 2018, 8:42 PM

In D9708#192750, @hein wrote:

Let's nix the console.log() calls (unlike qDebug those don't go no-op in a rlease build), otherwise looks ready to go. Great work!

I ripped them out, thanks!

Revision Contents
Changeset List

			Path	Packages
M			src/common.h (16 lines)
M			src/connectionmanager.h (2 lines)
M			src/connectionmanager.cpp (14 lines)
M			src/irc/channel.h (2 lines)
M			src/irc/channel.cpp (8 lines)
M			src/irc/query.h (3 lines)
M			src/irc/query.cpp (9 lines)
M			src/irc/server.h (9 lines)
M			src/irc/server.cpp (38 lines)
M			src/mainwindow.h (1 line)
M			src/mainwindow.cpp (11 lines)
M			src/qtquick/uipackages/default/contents/ViewSwitcher.qml (31 lines)
M			src/viewer/chatwindow.h (2 lines)
M			src/viewer/chatwindow.cpp (7 lines)
M			src/viewer/viewcontainer.cpp (20 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	24877	6fa584a		Jan 7 2018, 1:45 PM	★	★
Diff 2	25571	6f33f78	Add namespace-level enum, fixes for Eike comments	Jan 17 2018, 10:09 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
48e34b138f0d	154679d13f3a	6f33f78dff26	Oleg Chernovskiy	Add progress loading icon to QtQuick server row (Show More…)	Jan 7 2018, 1:35 PM

	Status	Author	Revision
	Closed	Kanedias	D9708 Add progress loading icon to QtQuick server row
	Closed	Kanedias	D9804 Add BusyIndicator to the styled controls list

Add progress loading icon to QtQuick server rowClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 25571

src/common.h

src/connectionmanager.h

src/connectionmanager.cpp

src/irc/channel.h

src/irc/channel.cpp

src/irc/query.h

src/irc/query.cpp

src/irc/server.h

src/irc/server.cpp

src/mainwindow.h

src/mainwindow.cpp

src/qtquick/uipackages/default/contents/ViewSwitcher.qml

src/viewer/chatwindow.h

src/viewer/chatwindow.cpp

src/viewer/viewcontainer.cpp

Add progress loading icon to QtQuick server row
ClosedPublic
Actions

Revision Contents
Changeset List