Added service menu
ClosedPublic

Authored by michaelh on Jan 6 2018, 10:05 AM.

Details

Summary

BUG: 388559

Limitation:

  • Files must be presented in the same dolphin pane

Diff Detail

Repository
R454 Kompare
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
michaelh requested review of this revision.Jan 6 2018, 10:05 AM
michaelh created this revision.
michaelh edited the summary of this revision. (Show Details)Jan 6 2018, 10:16 AM
michaelh added a subscriber: mlaurent.
mlaurent requested changes to this revision.Jan 6 2018, 11:48 AM
mlaurent added inline comments.
servicemenus/kompare.desktop
7

remove theses 2 commented line please.

This revision now requires changes to proceed.Jan 6 2018, 11:48 AM
michaelh updated this revision to Diff 24824.Jan 6 2018, 12:13 PM
michaelh edited the summary of this revision. (Show Details)
  • removed comments
mlaurent accepted this revision.Jan 6 2018, 3:25 PM
This revision is now accepted and ready to land.Jan 6 2018, 3:25 PM

Wonderful! Thank you.

  1. I can't commit. Will you do that for me (ottwolt@gmail.com), please?
  2. I don't know how to handle the bug/wish. Could give me directions?
ngraham edited the summary of this revision. (Show Details)Jan 6 2018, 5:04 PM

If you put "BUG: 388559" on its own line, it becomes a special keyword that will close that bug once this goes in.

"FEATURE: 388559" does the same thing, but marks the change as a feature rather than a bug fix. So it might be appropriate to do that here!

safaalfulaij added inline comments.
servicemenus/kompare.desktop
10

I don't think it's wise to add translations here..

broulik added inline comments.
servicemenus/kompare.desktop
6

Can you compare directories?

9

I know the tool is "Kompare" but the menu entry should still be "Compare Files"

10

Translations get added by a script, so yes, please don't manually add them

michaelh marked 3 inline comments as done.Jan 8 2018, 11:32 AM
michaelh added inline comments.
servicemenus/kompare.desktop
6

Yes.

10

Thanks. Didn't know that.

michaelh updated this revision to Diff 24925.Jan 8 2018, 11:38 AM
michaelh marked 2 inline comments as done.
  • Removed translation
  • (Wrongly) silenced stderr
michaelh updated this revision to Diff 24929.Jan 8 2018, 11:41 AM
  • silenced stdout. To prevent 28 lines of help message going to ~/.local/share/sddm/xorg-session.log
michaelh updated this revision to Diff 24930.Jan 8 2018, 11:47 AM
  • Capitalized 'Compare files'
michaelh marked an inline comment as done.Jan 8 2018, 11:48 AM

I just made a KIO patch that allows you to specify the number of selected files required for an action to show up, 2 in this case. Just add

X-KDE-RequiredNumberOfUrls=2

to the desktop file, see D9734

michaelh updated this revision to Diff 25074.Jan 10 2018, 10:55 AM
michaelh edited the summary of this revision. (Show Details)

added "X-KDE-RequiredNumberOfUrls=2"

Other than that looking good!

servicemenus/kompare.desktop
12

Why > /dev/null?

Without it kompare prints its help > ~/.local/share/sddm/xorg-session.log
Your KIO patch should make "> /dev/null" obsolete, let's see.

This revision was automatically updated to reflect the committed changes.