| aacid | |
| rkflx |
| Okular |
BUG: 388511
New dialog:
Both buttons still work to do what they say they'll do.
| No Linters Available |
| No Unit Test Coverage |
You should open a 48h bugfixing service ;)
Example PDF (via https://tex.stackexchange.com/a/219791):
| part.cpp | ||
|---|---|---|
| 1626–1627 | While testing, I thought "The last sentence should be on a new line", because a narrower dialog would be easier to read. And indeed, looking at the code there was a line break before. Please keep it. | |
| 1628 | Why not just Cancel? Seems more common to me. Perhaps use KStandardGuiItem::cancel() and manually setToolTip()? | |
| part.cpp | ||
|---|---|---|
| 1628 | I considered that, but that button doesn't actually cancel anything; it just doesn't do the proposed action. | |
Now we have "Presentation Mode" (title), "Presentation Mode" (first sentence), "Presentation Mode" (second sentence), "Presentation Mode" (button). I find it a bit annoying to read ;) Can we do something about it, e.g. by removing the second sentence? Any other idea?
(Nice idea with the "Stay here").
Yep. Take your time with rephrasing, it's 18.04 material anyway. Also, it should probably stay being a question (because it's not a warning or information either), hence the question mark icon.
(Helps saving inline comments before pressing "Submit").
| part.cpp | ||
|---|---|---|
| 1627–1631 | Title Case for buttons, IIRC? | |
How about this?
It's is an innovative idea, but unless there are any other existing examples putting the question in the title, I'm afraid I would not recommend to do this here.
Maybe something with "Honor the request ... allow to ... to be shown ... switch to ... fullscreen...?"? This way we would rephrase the term Presentation Mode a bit for anyone not knowing what it means. On the other hand, the real fullscreen mode is different again. But perhaps you can take it from here.
Another idea: Say where we are switching from. Or simply ask whether the user allows to switch modes at all (with the actual mode only in the title and on the button).
Sounds great. Maybe "View Mode" in the title? ("Mode" is not really meaningful in itself.)
Also: Title Case in title, I guess?
Do you think Albert should approve this?
More polish:
I try to add Albert as a reviewer for Okular patches since he is/was/has been a maintainer.
That's even better. Just update the Diff, I'll check / approve and then we'll see what Albert says.
Honestly I'm not thrilled with "Stay Here", though I'm not a native English speaker either.
I think that Keep would be a better verb than Stay and "Here" is kind of weird since this dialog will most likely open when you open a file, so most probably you didn't even have Okular open yet, so what is "Here"?
One obvious solution is "Do not enter presentation mode", but that's probably too similar word wise and may be confusing then there's "Keep Regular View Mode" or something similar.
I wasn't 100% sold on "Stay Here" either, but it was the best I could come up with at the time. That said, Okular's main window is definitely visible by the time the dialog shows up, so "here" would visually refer to that.
How about this?
What is Normal Mode to the user, anyway? It's not bad, but does not click with me immediately, TBH.
How about Deny Request? That would correspond nicely with the title.
You can not change translatable text in a stable branch unless the source English text is clearly broken and will lead to horrible things happening. And this is not one of those cases by far.
