To Jean
Needs ReviewPublic
Actions

Authored by maheshsnair on Jan 5 2018, 2:28 PM.

Details

Repository

R158 Kdenlive

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

maheshsnair requested review of this revision.Jan 5 2018, 2:28 PM

maheshsnair created this revision.

Ok, so I don't see the audiomixer.cpp/h files, you need to add them using git:

git add mixer/audiomixer.cpp mixer/audiomixer.h

and make the diff again. But please first check my comments

src/core.h
26	You should not define any method here. Just leave the class mention, to make the compiler understand the class: class Audiomixer;
src/mainwindow.h
43	Audiomixer class is not used in the header file, so this line is not necessary
58	No need for this class, remove.

Changes made

		Path
M		src/CMakeLists.txt (2 lines)
M		src/core.h (5 lines)
M		src/core.cpp (23 lines)
M		src/mainwindow.h (4 lines)
M		src/mainwindow.cpp (5 lines)
A	M	src/mixer/audiomixer.h (15 lines)
A	M	src/mixer/audiomixer.cpp (11 lines)