Show only available profiles in Pulseaudio KCM
ClosedPublic
Actions

Authored by nicolasfella on Jan 5 2018, 1:35 AM.

Details

Reviewers

Group Reviewers

Commits

R994:206a00f95858: Move availability property from Port to Profile
R115:206a00f95858: Move availability property from Port to Profile

Summary

Pulseaudio tells us whether a profile is available or not. Right now, all profiles are shown. This patch limits the selection to the available ones, making it a bit easier to choose the right one.

Test Plan

Compare to output of 'pactl show cards'. Add and remove audio sinks.

Diff Detail

Repository

R115 Plasma Audio Volume Applet

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

nicolasfella created this revision.Jan 5 2018, 1:35 AM

Restricted Application added a subscriber: plasma-devel. · View Herald TranscriptJan 5 2018, 1:35 AM

nicolasfella requested review of this revision.Jan 5 2018, 1:35 AM

Filtering gives us wrong indices

I'm ok with the part of the patch that moves availability property from Port to Profile. Adding availableProfiles is not a good way to achieve what you want though. Profiles should be filtered on QML side.

I'd like to have this in, do you think you could finish it? If not, I will take over.

Feel free to take over, I can't promise to finish it anytime soon

This revision was not accepted when it landed; it landed in state Changes Planned.Jan 27 2018, 6:03 PM

Closed by commit R115:206a00f95858: Move availability property from Port to Profile (authored by nicolasfella, committed by drosca). · Explain Why

This revision was automatically updated to reflect the committed changes.

This breaks the context menu of output devices:

org.kde.plasma.volume/contents/ui/ListItemBase.qml:315: ReferenceError: Port is not defined

In D9671#200326, @broulik wrote:
This breaks the context menu of output devices:
org.kde.plasma.volume/contents/ui/ListItemBase.qml:315: ReferenceError: Port is not defined

see D10280

akrutzler mentioned this in D13694: Fix wrong availability of profiles and ports..Jun 23 2018, 10:56 AM

drosca mentioned this in R115:ba737f478208: Fix wrong availability of profiles and ports..Jun 29 2018, 7:41 AM

nicolasfella mentioned this in R115:b97846017df5: Fix wrong availability of profiles and ports..Jul 10 2018, 11:15 AM