Use cmake function 'kdbusaddons_generate_dbus_service_file' from kdbusaddons to generate dbus service file
ClosedPublic

Authored by habacker on Jan 4 2018, 10:08 PM.

Details

Summary

BUG:382459
BUG:388059
BUG:388060
BUG:388062
BUG:388063
FIXED-IN:5.42.0

Test Plan

compiled against installed HEAD of kdbusaddons git master branch and inspected generated service files;
On Windows only the executable is used, which is expected

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
habacker created this revision.Jan 4 2018, 10:08 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptJan 4 2018, 10:08 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
habacker requested review of this revision.Jan 4 2018, 10:08 PM
habacker updated this revision to Diff 24890.Jan 7 2018, 5:55 PM
  • 5.42.0 is out, update version to 5.43.0
dfaure accepted this revision.Jan 7 2018, 6:07 PM
This revision is now accepted and ready to land.Jan 7 2018, 6:07 PM
This revision was automatically updated to reflect the committed changes.
  • 5.42.0 is out, update version to 5.43.0

The patch update demonstrates a surprising phabricator behavior not updating commit messages - where should I report it ?

As a KDE sysadmin ticket; the sysadmins want to centralize KDE's issues with Phabricator before reporting them upstream (to present a unified front and avoid duplicates).

thanks for this pointer, see T7711

FYI, I can't, it's a "private" issue by default.

Add you as subscriber.