Fix theme changing and other theme/ui improvements
ClosedPublic

Authored by scottpetrovic on Jan 4 2018, 7:06 PM.

Details

Reviewers
woltherav
Group Reviewers
Krita
Summary

This is all in my petrovic/theme-update branch if you want to see more bit size chunks of each change and exactly what is included.

  1. Fix a caching issue that was causing most of the icons not to change on theme change
  2. Fixed some additional areas that were not changing icons on theme change. I didn't get everything, but it should be quite a bit better than it previously was.
  3. Make the advanced color picker disabled looking when there is no documents open
  4. Make the curve widget look disabled when it is disabled (easiest to see in brush editor curves)
  5. Make layer visibilityicon greyed out if the layer is being hidden
  6. Improve layer progress indicator so it goes across entire layer name area under neath
  7. Improve how selected tab areas look when selected. Seen in brush tip type and selection tool tool options
  8. Use a neutral gray that is closer to the background theme color instead of a static grey
  9. change the overview selection rectangle color to use a theme instead of semi-hard coded to red
  10. Improved backgrounds for overview and histogram docker to be more consistent with other docker backgroudns
Test Plan

Did a lot of theme changing to see what was switching and what wasn't

Diff Detail

Repository
R37 Krita
Lint
Lint Skipped
Unit
Unit Tests Skipped
scottpetrovic requested review of this revision.Jan 4 2018, 7:06 PM
scottpetrovic created this revision.
rempt added a subscriber: rempt.EditedJan 8 2018, 1:57 PM

"Use a neutral gray that is closer to the background theme color instead of a static grey"

I still think that this is not a good change for the advanced color selector. It really should be plain mid-gray. For the rest I'm fine with the changes.

@rempt is there a specific reason that you prefer the mid gray?

This was my logic for the decision. Making the background a fixed color doesn't fit in with the rest of the color theming we do in every other part of the application. It puts a lot of attention on that area of the UI since it is doing something not consistent with the rest of the UI. Maybe we can get some other artists to chime in with what they think.

Examples of other programs that don't use a mid grey
Affinity (dark) - https://affinity.help/designer/en-US.lproj/images/panel_clr_wheel.png
Coolorus (Photoshop - dark) - https://78.media.tumblr.com/d11b3bcc92fe8c40f246072b11708094/tumblr_inline_nppvdolasX1t1qqx1_500.png
Coolorus (Photoshop - light) - https://coolorus.com/images/coolorus_gamut_lock_screen_flat.png
Medibang - https://medibangpaint.com/en/wp-content/themes/cloudalpaca.com/images/pc/product-main-device.png

In all the examples I found across various programs the background color relates to the theme color. The only one I found that uses a mid grey is Painter...but the entire theme and UI is also a mid grey with that.

I don't have a really strong opinion. I was coming at it from a perspective that it doesn't stand out so much on the UI.

After talking with a few artists we are going to keep it at 50% grey -- regardless of what other applications are doing. The leading reason to keep it at 50% grey is that it minimizes the chance your eyes will be fooled with local colors. My examples are about UI consistency which is nice...but I think functional reasons should override aesthetic reasons.

I will revert that commit.

Does anyone else need to look at these changes?

woltherav accepted this revision.Jan 8 2018, 7:34 PM
woltherav added a subscriber: woltherav.

No, push it :)

This revision is now accepted and ready to land.Jan 8 2018, 7:34 PM
scottpetrovic closed this revision.Feb 28 2018, 1:39 PM

This wad pushed out and I forgot to close it